Install local dff in tutorial tests #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, every PR with additions (e.g. new dependencies or modules) fails due to tutorial tests which run
pip install dffinstalling an older version from pypi.This PR makes tutorial tests install local up-to-date dff.
Due to
coverageworkflow removing thedffdirectory from testing environment, this test cannot be run incoverageworkflow (which is not a big problem since this test does not contribute to coverage at all).Failing tests in
feat/db-benchmark:5e604bd
Successful tests with this patch:
8c79160
Checklist